[libcxx-commits] [libcxx] Compile MSAN/TSAN failing test with -O1 (PR #73555)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 27 10:54:29 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Eric (EricWF)

<details>
<summary>Changes</summary>

This attempts to fix flakes on the bots where the modified test times out while running under sanitizers.

Turning on the optimizer for just this test appears to mostly fix the issue.

---
Full diff: https://github.com/llvm/llvm-project/pull/73555.diff


1 Files Affected:

- (modified) libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp (+3) 


``````````diff
diff --git a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
index 946c2cfabf02b63..d3d731bbb1029ca 100644
--- a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
+++ b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
@@ -9,6 +9,9 @@
 // REQUIRES: long_tests
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
+// This test chokes on the sanitizers during CI runs. It appears we can address most of this by simply enabling optimizations.
+// ADDITIONAL_COMPILE_FLAGS: -DFOO
+
 // <deque>
 
 // template <class InputIterator>

``````````

</details>


https://github.com/llvm/llvm-project/pull/73555


More information about the libcxx-commits mailing list