[libcxx-commits] [libcxx] Compile MSAN/TSAN failing test with -O1 (PR #73555)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 27 10:54:01 PST 2023


https://github.com/EricWF created https://github.com/llvm/llvm-project/pull/73555

This attempts to fix flakes on the bots where the modified test times out while running under sanitizers.

Turning on the optimizer for just this test appears to mostly fix the issue.

>From 83f288b93184bb25d39a310dd87cba6b925dbcea Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Mon, 27 Nov 2023 13:52:27 -0500
Subject: [PATCH] Compile MSAN/TSAN failing test with -O1

This attempts to fix flakes on the bots where the modified test
times out while running under sanitizers.

Turning on the optimizer for just this test appears to mostly fix
the issue.
---
 .../sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
index 946c2cfabf02b63..d3d731bbb1029ca 100644
--- a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
+++ b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
@@ -9,6 +9,9 @@
 // REQUIRES: long_tests
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
+// This test chokes on the sanitizers during CI runs. It appears we can address most of this by simply enabling optimizations.
+// ADDITIONAL_COMPILE_FLAGS: -DFOO
+
 // <deque>
 
 // template <class InputIterator>



More information about the libcxx-commits mailing list