[libcxx-commits] [libcxx] Compile MSAN/TSAN failing test with -O1 (PR #73555)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 27 10:56:12 PST 2023


https://github.com/EricWF updated https://github.com/llvm/llvm-project/pull/73555

>From 3249c119de11abd8c580586823da5b37a06c10db Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Mon, 27 Nov 2023 13:52:27 -0500
Subject: [PATCH] Compile MSAN/TSAN failing test with -O1

This attempts to fix flakes on the bots where the modified test
times out while running under sanitizers.

Turning on the optimizer for just this test appears to mostly fix
the issue.
---
 .../sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp  | 3 +++
 .../rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp         | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
index 946c2cfabf02b63..60eeeab673dd127 100644
--- a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
+++ b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
@@ -9,6 +9,9 @@
 // REQUIRES: long_tests
 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
 
+// This test chokes on the sanitizers during CI runs. It appears we can address most of this by simply enabling optimizations.
+// ADDITIONAL_COMPILE_FLAGS: -O1
+
 // <deque>
 
 // template <class InputIterator>
diff --git a/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp b/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
index d98a73d296668bb..6fbef7c948a60ec 100644
--- a/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
+++ b/libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
@@ -8,6 +8,9 @@
 //
 // REQUIRES: long_tests
 
+// This test chokes on the sanitizers during CI runs. It appears we can address most of this by simply enabling optimizations.
+// ADDITIONAL_COMPILE_FLAGS: -O1
+
 // <random>
 
 // template<class IntType = int>



More information about the libcxx-commits mailing list