[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added inline comments.


================
Comment at: libcxx/docs/Modules.rst:42
+   not handle that case properly.
+ * There is no `P1689 style output <https://wg21.link/P1689>`_ yet.
+ * The experimental library (read <format>) does not work as expected
----------------
Mordante wrote:
> ChuanqiXu wrote:
> > P1689 format is supported in clang-scan-deps. What's the reason we can't make it now?
> We can make it, that's no problem. However that file needs the use the installation path and not the path in the build directory. So the output needs a search and replace, but I don't know yet what the proper replace value will be.
> 
> I put this item here so we don't forget about including it.
I still don't understand. No matter where the source files is, the output of P1689 format should be generated during the building and I think we shouldn't port them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994