[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 9 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/docs/Modules.rst:42
+   not handle that case properly.
+ * There is no `P1689 style output <https://wg21.link/P1689>`_ yet.
+ * The experimental library (read <format>) does not work as expected
----------------
ChuanqiXu wrote:
> Mordante wrote:
> > ChuanqiXu wrote:
> > > P1689 format is supported in clang-scan-deps. What's the reason we can't make it now?
> > We can make it, that's no problem. However that file needs the use the installation path and not the path in the build directory. So the output needs a search and replace, but I don't know yet what the proper replace value will be.
> > 
> > I put this item here so we don't forget about including it.
> I still don't understand. No matter where the source files is, the output of P1689 format should be generated during the building and I think we shouldn't port them.
Using 
`clang-scan-deps-17  -format=p1689 -compilation-database compile_commands.json`
The output looks like
```
{
  "revision": 0,
  "rules": [
    {
      "primary-output": "CMakeFiles/std.dir/std-coroutine.cppm.o",
      "provides": [
        {
          "is-interface": true,
          "logical-name": "std:coroutine",
          "source-path": "<build-dir>/include/c++/modules/std-coroutine.cppm"
        }
      ]
    },
```
Where `<build-dir>` is the place where I copied the `cppm` files to. This output seems quite useless, since it's tied to a specific machine. Do you have suggestions how to get less my-system-specific paths?


================
Comment at: libcxx/docs/Modules.rst:43
+ * There is no `P1689 style output <https://wg21.link/P1689>`_ yet.
+ * The experimental library (read <format>) does not work as expected
+
----------------
ChuanqiXu wrote:
> aaronmondal wrote:
> > 
> I doesn't get this after I read `<format>`. What happened and what is expected?
I expected that I was able to type ;-) So it was an error on my side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994