[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

Thu Mar 2 12:06:37 PST 2023

Mordante marked 3 inline comments as done.
Mordante added a comment.

In D144994#4165266 <https://reviews.llvm.org/D144994#4165266>, @tschuett wrote:

> Really stupid question^{TM}: if you would put the cppm files into the include directory and provide cmake files to integrate into out-of-tree projects.
>
>   > ninja install-cmake-exports install-mlir-cmake-exports
>
> LLVM installs theses cmake files so that other cmake projects can include them in their project. User could integrate files into their cmake project and have a target to build the pcm files.

My current intention is indeed to ship it with a cmake file and with a P1689 <https://reviews.llvm.org/P1689> file. Using the include directory or a directory below it is certainly possible. My main point is, what we decide we need to stick with "forever" so it warrants some time and consideration. Note there are a several other open questions for this patch, which need to be discussed.

================
Comment at: libcxx/docs/Modules.rst:42
+   not handle that case properly.
+ * There is no `P1689 style output <https://wg21.link/P1689>`_ yet.
+ * The experimental library (read <format>) does not work as expected
----------------
ChuanqiXu wrote:
> P1689 format is supported in clang-scan-deps. What's the reason we can't make it now?
We can make it, that's no problem. However that file needs the use the installation path and not the path in the build directory. So the output needs a search and replace, but I don't know yet what the proper replace value will be.

I put this item here so we don't forget about including it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994