[libcxx-commits] [PATCH] D152439: [libc++] Add "REQUIRES: long_tests" to two libc++ tests

[Mikhail Maltsev via Phabricator via libcxx-commits]

miyuki added a comment.

In D152439#4405979 <https://reviews.llvm.org/D152439#4405979>, @philnik wrote:

> A test on one machine could be very slow while it's negligible on another. Some tests that are marked `long_tests` take ~0.5 seconds on my machine, which is definitely not slow.

Yes, I am running these tests on a simulator and eval.PR44847.pass.cpp takes ~10 minutes. I used x86 as an example because that's what others can use to reproduce the result.

> Just having a timeout and the option to ignore timeouts in lit would make a lot more sense IMO.

But that would hide real bugs, e.g. miscompilations that create infinite loops.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152439/new/

https://reviews.llvm.org/D152439