[libcxx-commits] [PATCH] D152439: [libc++] Add "REQUIRES: long_tests" to two libc++ tests

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 8 08:46:51 PDT 2023


philnik added a comment.

I'm really not convinced that this flag makes any sense. Most importantly: A test on one machine could be very slow while it's negligible on another. Some tests that are marked `long_tests` take ~0.5 seconds on my machine, which is definitely not slow. Just having a timeout and the option to ignore timeouts in lit would make a lot more sense IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152439/new/

https://reviews.llvm.org/D152439



More information about the libcxx-commits mailing list