[libcxx-commits] [PATCH] D152439: [libc++] Add "REQUIRES: long_tests" to two libc++ tests

Thu Jun 8 09:07:49 PDT 2023

philnik added a comment.

In D152439#4406038 <https://reviews.llvm.org/D152439#4406038>, @miyuki wrote:

> In D152439#4405979 <https://reviews.llvm.org/D152439#4405979>, @philnik wrote:
>
>> A test on one machine could be very slow while it's negligible on another. Some tests that are marked `long_tests` take ~0.5 seconds on my machine, which is definitely not slow.
>
> Yes, I am running these tests on a simulator and eval.PR44847.pass.cpp takes ~10 minutes. I used x86 as an example because that's what others can use to reproduce the result.
>
>> Just having a timeout and the option to ignore timeouts in lit would make a lot more sense IMO.
>
> But that would hide real bugs, e.g. miscompilations that create infinite loops.

Possibly, but these tests are for the library, not the compiler. Anyways, you can still keep a list of tests that time out and check that there isn't anything unexpected timing out. Given that the list of slow tests can be different on every platform, I don't see how we could keep a reasonable list of slow tests without losing coverage. Another option I just remembered is that you can disable specific tests through `--filter-out`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152439/new/

https://reviews.llvm.org/D152439