[libcxx-commits] [PATCH] D152439: [libc++] Add "REQUIRES: long_tests" to two libc++ tests

Mikhail Maltsev via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 8 06:01:19 PDT 2023


miyuki created this revision.
miyuki added reviewers: ldionne, Mordante.
Herald added a subscriber: pengfei.
Herald added a project: All.
miyuki requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Currently, we use the lit feature "long_tests" for libc++ tests that
take a long time to run so that they can be disabled by users.

This patch marks the following two tests:

- std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
- numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.bin/eval.PR44847.pass.cpp

with "REQUIRES: long_tests".

The run time of these tests is similar to that of other tests already
marked as "long_tests". For example, on an x86-64 machine with an
i7-6700 CPU running at 3.4 GHz, an existing long test
std/numerics/rand/rand.dist/rand.dist.pois/rand.dist.pois.weibull/eval_param.pass.cpp
takes 1.07 seconds, whereas eval.PR44847.pass.cpp takes 1.27 seconds,
sort.pass.cpp takes 39.10 seconds.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152439

Files:
  libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
  libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.bin/eval.PR44847.pass.cpp


Index: libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.bin/eval.PR44847.pass.cpp
===================================================================
--- libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.bin/eval.PR44847.pass.cpp
+++ libcxx/test/std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.bin/eval.PR44847.pass.cpp
@@ -8,6 +8,8 @@
 
 // <random>
 
+// REQUIRES: long_tests
+
 // template<class IntType = int>
 // class binomial_distribution
 
Index: libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
===================================================================
--- libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
+++ libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
@@ -6,6 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: long_tests
+
 // <algorithm>
 
 // template<RandomAccessIterator Iter>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152439.529571.patch
Type: text/x-patch
Size: 972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230608/258cabf4/attachment.bin>


More information about the libcxx-commits mailing list