[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

Mon Jun 5 09:25:59 PDT 2023

philnik added a comment.

In D139147#4386265 <https://reviews.llvm.org/D139147#4386265>, @rprichard wrote:

> In D139147#4386100 <https://reviews.llvm.org/D139147#4386100>, @philnik wrote:
>
>> In D139147#4386090 <https://reviews.llvm.org/D139147#4386090>, @rprichard wrote:
>>
>>> I was wondering whether I can land this patch adding Android testing to buildkite-pipeline.yml while the Android libc++ tests are still failing, or if the buildbot isn't set up yet. e.g. I wouldn't want non-Android-related LLVM patches to be affected. (Maybe I should land all the Android-related work first, and only then add the entry to the yml file.)
>>
>> I think the way to go is marking all the failing tests as `XFAIL` and go from there. This avoids regressions and makes it easier to verify that a patch actually does what it claims to do.
>
> These are the currently-failing tests with just this patch, https://gist.github.com/rprichard/4a8e9b160e7adc472778699c62ae1fff.
>
> I can mark these tests as XFAIL. Would I do that in this patch or could I do that in an earlier commit?

Both options seem fine to me. Adding them in an earlier commit would probably make sense to keep this patch a bit more focused.

>>> This patch has a Dockerfile.android that produces a libcxx-builder-android image -- I just need to publish it somewhere. I think we want to keep the Android stuff out of the main ldionne/libcxx-builder Docker image because it's big? When I measured it back in December, adding Android support would increase the size from 4.7GB to 12.5GB. The Android SDK is large (6.8G), and I also need to install the `openjdk-11-jdk` Ubuntu package (400M). The buildbot could download the SDK when it starts, but then a local run of `run-buildbot android-ndk` would be slow.
>>
>> That is indeed quite a lot of extra data. Maybe we could just have a second image `ldionne/libcxx-builder-android`. Then everybody who has to can access and update it without problems.
>
> Yes, a second image makes sense to me. I'm not sure who should own it, but since @ldionne generates the base image, it could also make sense for him to generate the Android-specific one that builds on it.

There are actually a few core contributor who can update the image. The ones I'm aware of are myself, Mark and Louis. I think it would make sense that we could update the android image and whoever is our Android contact (I guess that's you?).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147