[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard added a comment.

In D139147#4386265 <https://reviews.llvm.org/D139147#4386265>, @rprichard wrote:

> In D139147#4386100 <https://reviews.llvm.org/D139147#4386100>, @philnik wrote:
>
>> In D139147#4386090 <https://reviews.llvm.org/D139147#4386090>, @rprichard wrote:
>>
>>> I was wondering whether I can land this patch adding Android testing to buildkite-pipeline.yml while the Android libc++ tests are still failing, or if the buildbot isn't set up yet. e.g. I wouldn't want non-Android-related LLVM patches to be affected. (Maybe I should land all the Android-related work first, and only then add the entry to the yml file.)
>>
>> I think the way to go is marking all the failing tests as `XFAIL` and go from there. This avoids regressions and makes it easier to verify that a patch actually does what it claims to do.
>
> These are the currently-failing tests with just this patch, https://gist.github.com/rprichard/4a8e9b160e7adc472778699c62ae1fff.
>
> I can mark these tests as XFAIL. Would I do that in this patch or could I do that in an earlier commit?

For AIX, it looks like some initial test code was added in D111244 <https://reviews.llvm.org/D111244>. Later, D111359 <https://reviews.llvm.org/D111359> defined LIBCXX-AIX-FIXME, marked the test files, and added the entry in buildkite-pipeline.yml.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147