[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D139147#4386090 <https://reviews.llvm.org/D139147#4386090>, @rprichard wrote:

> I was wondering whether I can land this patch adding Android testing to buildkite-pipeline.yml while the Android libc++ tests are still failing, or if the buildbot isn't set up yet. e.g. I wouldn't want non-Android-related LLVM patches to be affected. (Maybe I should land all the Android-related work first, and only then add the entry to the yml file.)
>
> I'm also wondering how the buildbot is restarted when the ldionne/libcxx-builder Docker image changes.
>
> In D139147#4384537 <https://reviews.llvm.org/D139147#4384537>, @philnik wrote:
>
>> In D139147#4382747 <https://reviews.llvm.org/D139147#4382747>, @rprichard wrote:
>>
>>> I still haven't added anything to libcxx/utils/ci/buildkite-pipeline.yml. It's not clear to me whether that should be part of this patch, because there are several things that must happen first before CI tests will work:
>>>
>>> - I need to create a new docker image to add the Android stuff to it, and host it somewhere.
>>> - I need to setup a special buildbot on a VM somewhere that uses the new docker image.
>>
>> You don't have to use a Docker image for a CI bot. Although it would be really nice, this is not a requirement, and if you want to do this it can still be done later.
>
> This patch has a Dockerfile.android that produces a libcxx-builder-android image -- I just need to publish it somewhere. I think we want to keep the Android stuff out of the main ldionne/libcxx-builder Docker image because it's big? When I measured it back in December, adding Android support would increase the size from 4.7GB to 12.5GB. The Android SDK is large (6.8G), and I also need to install the `openjdk-11-jdk` Ubuntu package (400M). The buildbot could download the SDK when it starts, but then a local run of `run-buildbot android-ndk` would be slow.
>
>>> - There are a bunch of patches I have uploaded to Phabricator currently that are required to get tests running cleanly.
>>
>> Any tests that fail can be marked `LIBCXX-ANDROID-FIXME` for now. Or do you mean something more general?
>
> It's not that many patches, but Android isn't a properly supported target yet in libc++, so maybe that discouraged reviewing? Some of the patches are small but required to make many tests work, e.g. D137130 <https://reviews.llvm.org/D137130> and D137131 <https://reviews.llvm.org/D137131> in particular. D139497 <https://reviews.llvm.org/D139497> is needed to get three tests passing. D137129 <https://reviews.llvm.org/D137129> is also simple and fixes one test.

I'm not discouraged reviewing this, especially since it adds CI support. But several of us work as volunteer which means we have limited time to work on libc++.

For the way forward, I've a question. What is the intention regarding running the CI?

Are you going to host it yourself like AIX/FreeBSD do or is it the intention the run on our existing Linux runners?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147