[libcxx-commits] [PATCH] D154860: [NFC][libc++][bitset] Refactors constructors.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ green CI.



================
Comment at: libcxx/include/bitset:117
 #include <__assert> // all public C++ headers provide the assertion handler
 #include <__bit_reference>
 #include <__config>
----------------
Commit message typo: `commont`.


================
Comment at: libcxx/include/bitset:710
+        typename basic_string<_CharT, _Traits, _Allocator>::size_type __n =
+            (basic_string<_CharT, _Traits, _Allocator>::npos),
+        _CharT __zero = _CharT('0'),
----------------
Any reason for this being in parens? I'd remove them if we can, while we're at it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154860/new/

https://reviews.llvm.org/D154860