[libcxx-commits] [PATCH] D154860: [NFC][libc++][bitset] Refactors constructors.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.

Thanks for the cleanup. LGTM with comments addressed.



================
Comment at: libcxx/include/bitset:797
+    _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX23 void
+    __init(basic_string_view<_CharT, _Traits> __str, _CharT __zero, _CharT __one) {
+
----------------
Could we name this something along the lines of `__init_from_string`? We have `__init` in a bunch of places throughout the code base and in many places the overload set is completely impenetrable.


================
Comment at: libcxx/include/bitset:812
 
     _LIBCPP_INLINE_VISIBILITY
     size_t __hash_code() const _NOEXCEPT {return base::__hash_code();}
----------------
We might as well do that now, since the lines are being touched.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154860/new/

https://reviews.llvm.org/D154860