[libcxx-commits] [PATCH] D154860: [NFC][libc++][bitset] Refactors constructors.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 10 09:33:12 PDT 2023


Mordante created this revision.
Mordante added a reviewer: philnik.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Based on the review comments in D153201 <https://reviews.llvm.org/D153201> this combines the string and
c-string constructors. The commont constructor is using a string_view:

- it allows propagating the _Traits, which are required to be used for comparison.
- it avoids allocating
- libc++ supports it in C++03


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154860

Files:
  libcxx/include/bitset
  libcxx/test/libcxx/transitive_includes/cxx03.csv
  libcxx/test/libcxx/transitive_includes/cxx11.csv
  libcxx/test/libcxx/transitive_includes/cxx14.csv
  libcxx/test/libcxx/transitive_includes/cxx17.csv
  libcxx/test/libcxx/transitive_includes/cxx20.csv
  libcxx/test/libcxx/transitive_includes/cxx23.csv
  libcxx/test/libcxx/transitive_includes/cxx26.csv

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154860.538698.patch
Type: text/x-patch
Size: 8425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230710/ba2a68a2/attachment.bin>


More information about the libcxx-commits mailing list