[libcxx-commits] [PATCH] D154590: [libc++] mark barrier constructor as constexpr and explicit in <barrier>

Tue Jul 11 12:05:27 PDT 2023

diamante0018 added a comment.

In D154590#4490760 <https://reviews.llvm.org/D154590#4490760>, @philnik wrote:

> In D154590#4490754 <https://reviews.llvm.org/D154590#4490754>, @diamante0018 wrote:
>
>> I will abandon this revision, as a discussion happened on the llvm discord, the implementation is not constexpr friendly and will need some extra attention that is beyond my capabilities and the initial scope of this revision
>
> I think the `explicit` part should be uncontroversial, in case you want to continue with that.

Okay, I will continue that if you wish. Let me push a diff without the constexpr changes.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154590/new/

https://reviews.llvm.org/D154590