[libcxx-commits] [PATCH] D154590: [libc++] mark barrier constructor as constexpr explicit in <barrier>

Edo via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 10 08:50:31 PDT 2023


diamante0018 added a comment.

In D154590#4485489 <https://reviews.llvm.org/D154590#4485489>, @Mordante wrote:

> Are you still having troubles with parts of this patch?

Yes, unfortunately, despite me trying to understand already existing test files I was unable to figure out the proper syntax to test for explicit.
barrier's class takes two parameters, I don't know what syntax I should use for `test_convertible` because the second parameter is a function.
I might also need a bit of help for the constexpr test.
Thanks for asking.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154590/new/

https://reviews.llvm.org/D154590



More information about the libcxx-commits mailing list