[libcxx-commits] [PATCH] D154590: [libc++] mark barrier constructor as constexpr explicit in <barrier>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Are you still having troubles with parts of this patch?



================
Comment at: libcxx/test/std/thread/thread.barrier/ctor.pass.cpp:25
+#if TEST_STD_VER >= 11
+#  include "test_convertible.h"
+#endif
----------------
Can this header be included unconditionally?


================
Comment at: libcxx/test/std/thread/thread.barrier/ctor.pass.cpp:30
+TEST_CONSTEXPR_CXX20 bool test() {
+  return true;
+}
----------------
This test does nothing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154590/new/

https://reviews.llvm.org/D154590