[libcxx-commits] [PATCH] D154590: [libc++] mark barrier constructor as constexpr explicit in <barrier>

Edo via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 10 08:55:27 PDT 2023


diamante0018 added inline comments.


================
Comment at: libcxx/test/std/thread/thread.barrier/ctor.pass.cpp:25
+#if TEST_STD_VER >= 11
+#  include "test_convertible.h"
+#endif
----------------
Mordante wrote:
> Can this header be included unconditionally?
Does not look like it. A lot of already existing tests file include this header conditionally. That's the general understanding I have of this file


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154590/new/

https://reviews.llvm.org/D154590



More information about the libcxx-commits mailing list