[libcxx-commits] [PATCH] D142608: [libc++] Add [[clang::lifetimebound]] to min/max algorithms

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jan 29 05:01:04 PST 2023


philnik added inline comments.


================
Comment at: libcxx/include/module.modulemap.in:303
+        private header "__algorithm/minmax.h"
+        export *
+      }
----------------
Mordante wrote:
> Can you specify what exactly is exported. The `*` seems quite fragile when refactoring header includes.
I tried that and couldn't find out what exactly the problem is. I'd rather try to fix it in a separate patch, since it doesn't seem super important and might be quite a bit of work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142608/new/

https://reviews.llvm.org/D142608



More information about the libcxx-commits mailing list