[libcxx-commits] [PATCH] D142608: [libc++] Add [[clang::lifetimebound]] to min/max algorithms

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo one remark. Note the CI failure has already been fixed.



================
Comment at: libcxx/include/module.modulemap.in:303
+        private header "__algorithm/minmax.h"
+        export *
+      }
----------------
Can you specify what exactly is exported. The `*` seems quite fragile when refactoring header includes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142608/new/

https://reviews.llvm.org/D142608