[libcxx-commits] [PATCH] D142608: [libc++] Add [[clang::lifetimebound]] to min/max algorithms

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/module.modulemap.in:303
+        private header "__algorithm/minmax.h"
+        export *
+      }
----------------
philnik wrote:
> Mordante wrote:
> > Can you specify what exactly is exported. The `*` seems quite fragile when refactoring header includes.
> I tried that and couldn't find out what exactly the problem is. I'd rather try to fix it in a separate patch, since it doesn't seem super important and might be quite a bit of work.
SGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142608/new/

https://reviews.llvm.org/D142608