[libcxx-commits] [PATCH] D143975: [libcxx] Don't trigger -Wuser-defined-literals for headers in build

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

In D143975#4126246 <https://reviews.llvm.org/D143975#4126246>, @sunshaoce wrote:

>> #libc <https://reviews.llvm.org/tag/libc/> is blocking this patch to make sure it's approved by the people working on libc++.
>
> Thanks!
>
>   CMake
>       target_add_compile_flags_if_supported(${target} PRIVATE
>         -Wno-user-defined-literals
>         )
>
> It seems that this code does not work correctly. I think we can modify it to suppress the warning in the building stage.

It works in the CI and on my machine, so I suspect it's a problem with your configuration. Maybe the compiler is too old?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143975/new/

https://reviews.llvm.org/D143975