[libcxx-commits] [PATCH] D143975: [libcxx] Don't trigger -Wuser-defined-literals for headers in build

Shao-Ce SUN via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 14 08:29:55 PST 2023


sunshaoce added a comment.

> #libc <https://reviews.llvm.org/tag/libc/> is blocking this patch to make sure it's approved by the people working on libc++.

Thanks!

It seems that

  CMake
      target_add_compile_flags_if_supported(${target} PRIVATE
        -Wno-user-defined-literals
        )

It seems that this code does not work correctly. I think we can modify it to suppress the warning in the building stage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143975/new/

https://reviews.llvm.org/D143975



More information about the libcxx-commits mailing list