[libcxx-commits] [PATCH] D143975: [libcxx] Don't trigger -Wuser-defined-literals for headers in build

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

In D143975#4126246 <https://reviews.llvm.org/D143975#4126246>, @sunshaoce wrote:

>> #libc <https://reviews.llvm.org/tag/libc/> is blocking this patch to make sure it's approved by the people working on libc++.
>
> Thanks!
>
>   CMake
>       target_add_compile_flags_if_supported(${target} PRIVATE
>         -Wno-user-defined-literals
>         )
>
> It seems that this code does not work correctly. I think we can modify it to suppress the warning in the building stage.

Can you elaborate? Do you not see the compile flag passed through correctly when using `target_add_compile_flags_if_supported`?  Considering we use it below and pretty much everywhere else (including other projects in LLVM), I'm a bit suspicious.  Can you please explain your use case/specifically what you're doing, and what's not working, so we can best help?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143975/new/

https://reviews.llvm.org/D143975