[libcxx-commits] [PATCH] D143489: [libc++] Remove _LIBCPP_CONSTEVAL

Sat Feb 11 05:48:15 PST 2023

philnik added a comment.

In D143489#4120262 <https://reviews.llvm.org/D143489#4120262>, @Mordante wrote:

> In D143489#4110383 <https://reviews.llvm.org/D143489#4110383>, @ldionne wrote:
>
>> I think it must be because all supported compilers now support `consteval` in C++20 mode. Please add a motivation to the commit, but otherwise LGTM.
>
> I assume the same, but would be good to make sure.
>
> It seems the rebasing went wrong, therefore requesting changes.

What are you talking about? The diff looks fine to me and the CI failures look unrelated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143489/new/

https://reviews.llvm.org/D143489