[libcxx-commits] [PATCH] D143489: [libc++] Remove _LIBCPP_CONSTEVAL

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 11 05:35:38 PST 2023


Mordante requested changes to this revision.
Mordante added a comment.
This revision now requires changes to proceed.

In D143489#4110383 <https://reviews.llvm.org/D143489#4110383>, @ldionne wrote:

> I think it must be because all supported compilers now support `consteval` in C++20 mode. Please add a motivation to the commit, but otherwise LGTM.

I assume the same, but would be good to make sure.

It seems the rebasing went wrong, therefore requesting changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143489/new/

https://reviews.llvm.org/D143489



More information about the libcxx-commits mailing list