[libcxx-commits] [PATCH] D143489: [libc++] Remove _LIBCPP_CONSTEVAL

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D143489#4120271 <https://reviews.llvm.org/D143489#4120271>, @philnik wrote:

> In D143489#4120262 <https://reviews.llvm.org/D143489#4120262>, @Mordante wrote:
>
>> In D143489#4110383 <https://reviews.llvm.org/D143489#4110383>, @ldionne wrote:
>>
>>> I think it must be because all supported compilers now support `consteval` in C++20 mode. Please add a motivation to the commit, but otherwise LGTM.
>>
>> I assume the same, but would be good to make sure.
>>
>> It seems the rebasing went wrong, therefore requesting changes.
>
> What are you talking about? The diff looks fine to me and the CI failures look unrelated.

Weird, now the patch looks good. When I checked before there was no line with consteval in the at all.
Maybe a Phab hickup :-/

Sorry for the confusion, LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143489/new/

https://reviews.llvm.org/D143489