[libcxx-commits] [PATCH] D157363: [libc++][Modules] Remove unnecessary `requires` from the module map

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 11 14:24:45 PDT 2023


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

This makes sense to me, we had talked about doing this when we reviewed @iana 's original modulemap patch. The CI failure is only AIX, which is known to fail right now, so this LGTM.

However, we should be updating the `LIBCXX_CONFIGURED_WITHOUT_SUPPORT_FOR_THIS_HEADER` stuff in `CMakeLists.txt` as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157363/new/

https://reviews.llvm.org/D157363



More information about the libcxx-commits mailing list