[libcxx-commits] [PATCH] D157363: [libc++][Modules] Remove unnecessary `requires` from the module map

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 11 14:28:24 PDT 2023


iana added a comment.

In D157363#4581359 <https://reviews.llvm.org/D157363#4581359>, @ldionne wrote:

> This makes sense to me, we had talked about doing this when we reviewed @iana 's original modulemap patch. The CI failure is only AIX, which is known to fail right now, so this LGTM.
>
> However, we should be updating the `LIBCXX_CONFIGURED_WITHOUT_SUPPORT_FOR_THIS_HEADER` stuff in `CMakeLists.txt` as well.

I left the `LIBCXX_CONFIGURED_WITHOUT_SUPPORT_FOR_THIS_HEADER` stuff in `CMakeLists.txt` because the experimental headers are all still in a single module, so they still use `LIBCXX_ENABLE_LOCALIZATION`. I could get rid of the other ones, but I thought it was best to leave them all in case other experimental headers use other ones. Also if we go back to grouping private headers together, we'll need some more requires.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157363/new/

https://reviews.llvm.org/D157363



More information about the libcxx-commits mailing list