[libcxx-commits] [PATCH] D157363: [libc++][Modules] Remove unnecessary `requires` from the module map

[Ian Anderson via Phabricator via libcxx-commits]

iana added a comment.

In D157363#4580570 <https://reviews.llvm.org/D157363#4580570>, @Mordante wrote:

> In D157363#4578121 <https://reviews.llvm.org/D157363#4578121>, @iana wrote:
>
>> In D157363#4577404 <https://reviews.llvm.org/D157363#4577404>, @Mordante wrote:
>>
>>> LGTM, but I like @ldionne to have a look at this too.
>>> I assume we don't need to backport this patch to LLVM-17. Is that correct?
>>
>> I'm not really sure. If we want D157364 <https://reviews.llvm.org/D157364> for v17 because it adds things back to the `std` module that we removed, then we'll need this too.
>
> We backported the hard-coded `__std_clang_module header` to LLVM 17.
> We'll never add new headers to LLVM 17 so we don't need to backport the `__std_clang_module header` generator script.
>
> Does that answer your question? If not maybe reach out on Discord.

We did, but the hard coded `__std_clang_module` header didn't include as much things as the previous `std` module did since it put so many headers behind unnecessary macro guards. Maybe that's not a big deal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157363/new/

https://reviews.llvm.org/D157363