[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Fri Apr 21 10:41:19 PDT 2023

Mordante added a comment.

In D146190#4278503 <https://reviews.llvm.org/D146190#4278503>, @davidben wrote:

> In D146190#4278224 <https://reviews.llvm.org/D146190#4278224>, @Mordante wrote:
>
>> LGTM modulo the documentation issue. Please make sure the CI is green before landing. Note the sanitizers CI is currently broken and the AIX may also be offline. So feel free to ignore errors from these runners.
>
> Ack. Though I don't think I have bits to land things, so I'll need to wait for one of you all to do it anyway. :-)

Can you provide "your name <your at email.address>" then somebody can commit it on your behalf.

================
Comment at: libcxx/docs/index.rst:123
 Linux           i386, x86_64, arm, arm64  Only glibc-2.24 and later and no other libc is officially supported
-Windows         i386, x86_64              Both MSVC and MinGW style environments
+Windows         i386, x86_64              Both MSVC and MinGW style environments, ABI in MSVC environments is :doc:`unstable <ABIVersioning>`
 AIX 7.2TL5+     powerpc, powerpc64
----------------
davidben wrote:
> Mordante wrote:
> > 
> That didn't work (looks like `:ref:` is for links within a document), but I repro'd it and fixed it. Just was missing the `DesignDocs` path.
Odd it works for me locally and I have used this in the past. However the CI is happy so no need to change.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190