[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

David Benjamin via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 18 13:39:04 PDT 2023


davidben added a comment.

In D146190#4278224 <https://reviews.llvm.org/D146190#4278224>, @Mordante wrote:

> LGTM modulo the documentation issue. Please make sure the CI is green before landing. Note the sanitizers CI is currently broken and the AIX may also be offline. So feel free to ignore errors from these runners.

Ack. Though I don't think I have bits to land things, so I'll need to wait for one of you all to do it anyway. :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190



More information about the libcxx-commits mailing list