[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Fri Apr 21 20:42:18 PDT 2023

davidben added a comment.

In D146190#4287960 <https://reviews.llvm.org/D146190#4287960>, @Mordante wrote:

> In D146190#4278503 <https://reviews.llvm.org/D146190#4278503>, @davidben wrote:
>
>> In D146190#4278224 <https://reviews.llvm.org/D146190#4278224>, @Mordante wrote:
>>
>>> LGTM modulo the documentation issue. Please make sure the CI is green before landing. Note the sanitizers CI is currently broken and the AIX may also be offline. So feel free to ignore errors from these runners.
>>
>> Ack. Though I don't think I have bits to land things, so I'll need to wait for one of you all to do it anyway. :-)
>
> Can you provide "your name <your at email.address>" then somebody can commit it on your behalf.

David Benjamin <davidben at google.com>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190