[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Wed Apr 12 08:40:33 PDT 2023

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

In D146190#4256881 <https://reviews.llvm.org/D146190#4256881>, @davidben wrote:

> Re a few days, I added more notes to the documentation March 21st, which was about three weeks ago. :-) Also the original patch is over a year old now.

It's easy to sometimes miss a patch. Feel free ping after a week if you don't get feedback (for smaller patches; larger ones unfortunately always take a long time).

> Anyway, I'm happy to tweak this however folks prefer, but I'd need to know your preferences to do that. If folks are agreed on the direction and it's just documentation, I'm also happy to upload a follow-up patch to make further documentation changes if feedback comes in after the change lands.
>
> Timing-wise, this is a blocker for us using libc++'s `std::variant` and `std::optional` in Chromium. Right now we're using the Abseil polyfills, and I'm interested in moving to the STL implementation. We also have some code we're looking to extract into a standalone library with fewer dependencies, so STL types are ideal. But without this issue fixed, the libc++ types aren't usable for us, which leaves us in a bind.

I'm OK with landing this now if you commit to addressing any feedback Mark might have, since this is actually a blocker for you.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190