[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 11 12:06:06 PDT 2023


EricWF accepted this revision.
EricWF added a comment.

OK, lets try this again. Hopefully with cooler heads.

I've reviewed the LLVM code review guidance, and am comfortable that moving forward with this change today falls well within them.
@Mordante Feel free to leave additional feedback, and we'll make sure it's address post-commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190



More information about the libcxx-commits mailing list