[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Wed Apr 12 12:35:02 PDT 2023

davidben added a comment.

In D146190#4261827 <https://reviews.llvm.org/D146190#4261827>, @philnik wrote:

> I'm OK with landing this now if you commit to addressing any feedback Mark might have, since this is actually a blocker for you.

Sure! More than happy to tweak the documentation however you all like. Also happy to tweak the code based on feedback, though my sense is folks were happy with the direction (don't promise ABI for MSVC to avoid gating this on ABI versioning), and the concerns were just about where to say it.

(But if I'm wrong and the project's consensus ends up on using ABI versioning here, happy to sort that out too.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190