[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

[David Benjamin via Phabricator via libcxx-commits]

davidben added a comment.

Re a few days, I added more notes to the documentation March 21st, which was about three weeks ago. :-) Also the original patch is over a year old now.

Anyway, I'm happy to tweak this however folks prefer, but I'd need to know your preferences to do that. If folks are agreed on the direction and it's just documentation, I'm also happy to upload a follow-up patch to make further documentation changes if feedback comes in after the change lands.

Timing-wise, this is a blocker for us using libc++'s `std::variant` and `std::optional` in Chromium. Right now we're using the Abseil polyfills, and I'm interested in moving to the STL implementation. We also have some code we're looking to extract into a standalone library with fewer dependencies, so STL types are ideal. But without this issue fixed, the libc++ types aren't usable for us, which leaves us in a bind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190