[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Mon Apr 10 15:48:51 PDT 2023

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

In D146190#4256345 <https://reviews.llvm.org/D146190#4256345>, @philnik wrote:

> In D146190#4256333 <https://reviews.llvm.org/D146190#4256333>, @EricWF wrote:
>
>> I think this is ready. It LGTM. Lets just get the CI passing.
>
> Please wait for other people who have already commented. It's really not nice to overrule people like that, and this isn't exactly time sensitive.

Which issues are you talking about? They all seem to be resolved. There doesn't appear to be any blockers. If someone want's changes before this proceeds, there's a way to do that.
Otherwise, I feel comfortable that the objections have been addressed and this is ready to land. There's no need to wait.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190