[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

In D146190#4256667 <https://reviews.llvm.org/D146190#4256667>, @EricWF wrote:

> In D146190#4256345 <https://reviews.llvm.org/D146190#4256345>, @philnik wrote:
>
>> In D146190#4256333 <https://reviews.llvm.org/D146190#4256333>, @EricWF wrote:
>>
>>> I think this is ready. It LGTM. Lets just get the CI passing.
>>
>> Please wait for other people who have already commented. It's really not nice to overrule people like that, and this isn't exactly time sensitive.
>
> Which issues are you talking about? They all seem to be resolved. There doesn't appear to be any blockers. If someone want's changes before this proceeds, there's a way to do that.
> Otherwise, I feel comfortable that the objections have been addressed and this is ready to land. There's no need to wait.

In https://reviews.llvm.org/D146190#inline-1415505 Mark voiced concerns about the documentation and he didn't have a look whether the extended documentation suffices. That's why I'd like him to have a look. While I consider them to be resolved, I think there is nothing wrong with waiting a few days until he had a look. Again, there is no need to get this in as soon as possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190