[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

David Benjamin via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 10 14:32:20 PDT 2023


davidben added inline comments.


================
Comment at: libcxx/docs/DesignDocs/ABIVersioning.rst:26
+
+The exception to this is MSVC environments. Libc++ does not currently have users
+that require a stable ABI in MSVC environments, so MSVC-only changes may be
----------------
EricWF wrote:
> I agree with this. Is there anyway to call it out more prominently? 
Happy to put it wherever you all like. :-) Any place in particular? I put it in `index.rst`, with the supported platforms, and this file, which talks about ABI considerations, since those seemed the natural places.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190



More information about the libcxx-commits mailing list