[libcxx-commits] [PATCH] D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

> Do you mean that both unwind_shared and unwind_static both create a target named libunwind.a?

Yes, that's correct.

> Is there documentation for that CMake feature?

Very regrettably, this is not a documented feature yet (though it's tracked by issue https://gitlab.kitware.com/cmake/cmake/-/issues/19494). The behaviour exists only in AIX packaged versions of CMake to my knowledge (though work is underway to upstream it).

> I guess we could change the OUTPUT_NAME of the library, but that seems like kind of a hack.

Yes, I agree it is quite hackish. The AIX build is pretty reliant on being able to exclude the targets from the build at the moment though unfortunately, so if that is going away I'm afraid some sort of hackery will be required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134221/new/

https://reviews.llvm.org/D134221