[libcxx-commits] [PATCH] D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D134221#3833443 <https://reviews.llvm.org/D134221#3833443>, @daltenty wrote:

> In D134221#3833280 <https://reviews.llvm.org/D134221#3833280>, @ldionne wrote:
>
>> @daltenty I looked at the error in https://buildkite.com/llvm-project/libcxx-ci/builds/13649#01835770-a937-4a78-a82e-1dbe3add4e72 but I don't understand why there's a duplicate target producing `libunwind.a`. Could you please have a quick look? It doesn't reproduce when I use the AIX configuration locally on my mac.
>
> Ah, you've stumbled on some particular interestingness of CMake when it comes to AIX. AIX usually archives both shared libraries and static ones (one can actually mix the two in strange and interesting ways). Some versions of CMake on AIX implement this, so both the static and shared targets actually seem to come out with the same output names. We noticed this before but it worked ok for us in practice because we would configure for one or the other but not both.

Do you mean that both `unwind_shared` and `unwind_static` both create a target named `libunwind.a`? Is there documentation for that CMake feature? I guess we could change the `OUTPUT_NAME` of the library, but that seems like kind of a hack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134221/new/

https://reviews.llvm.org/D134221