[libcxx-commits] [PATCH] D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D134221#3833664 <https://reviews.llvm.org/D134221#3833664>, @daltenty wrote:

> Yes, I agree it is quite hackish. The AIX build is pretty reliant on being able to exclude the targets from the build at the moment though unfortunately, so if that is going away I'm afraid some sort of hackery will be required.

Since we already support setting the `OUTPUT_NAME` of libc++.dylib, I went ahead with that solution in D135669 <https://reviews.llvm.org/D135669>. That way, the output name can be customized in AIX's CMake cache with a comment explaining why that's required.

Note that more generally speaking, I would expect this to cause a lot of issues on AIX with existing CMake projects (libc++/libunwind isn't special in any way here). IMO CMake may want to handle this problem somehow, but I'm not sure how.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134221/new/

https://reviews.llvm.org/D134221