[libcxx-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 9 09:22:06 PST 2022


Mordante added a comment.

In D137724#3917616 <https://reviews.llvm.org/D137724#3917616>, @thieta wrote:

> I think this is fine as we have discussed before. But I really dislike the code duplication for the check. We could put it in a include() I guess - but maybe it's not worth it.

I wanted to make sure it shows up in different build scenarios. The code is temporary, once we switch to CMake 3.20.0 we can just change the `cmake_minimum_required` and remove these verbose blocks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137724/new/

https://reviews.llvm.org/D137724



More information about the libcxx-commits mailing list