[libcxx-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 9 09:40:03 PST 2022


MaskRay accepted this revision as: MaskRay.
MaskRay added a comment.

I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for standalone builds is not necessary. The check in `llvm/CMakeLists.txt` suffices.
It's unlikely the users will use different cmake versions to configure llvm and a subproject like clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137724/new/

https://reviews.llvm.org/D137724



More information about the libcxx-commits mailing list