[libcxx-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Tobias Hieta via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 9 09:17:59 PST 2022


thieta accepted this revision as: thieta.
thieta added a comment.
Herald added a reviewer: jdoerfert.
Herald added subscribers: sstefan1, JDevlieghere.

I think this is fine as we have discussed before. But I really dislike the code duplication for the check. We could put it in a include() I guess - but maybe it's not worth it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137724/new/

https://reviews.llvm.org/D137724



More information about the libcxx-commits mailing list