[libcxx-commits] [PATCH] D122017: [libc++] Rename __identity to __type_identity

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 19 10:48:37 PDT 2022


Mordante accepted this revision as: Mordante.
Mordante added a comment.

Nice catch! LGTM!



================
Comment at: libcxx/include/type_traits:1335
+template <class _Tp>
+using __type_identity_t _LIBCPP_NODEBUG = typename __type_identity<_Tp>::type;
+
----------------
I'm a bit puzzled why this is the only one using `_LIBCPP_NODEBUG`. @ldionne do you know whether this inconsistency is intended.
Note When we fix it, I prefer a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122017/new/

https://reviews.llvm.org/D122017



More information about the libcxx-commits mailing list