[libcxx-commits] [PATCH] D122017: [libc++] Rename __identity to __type_identity

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a subscriber: EricWF.
ldionne added a comment.
This revision is now accepted and ready to land.

Thanks a lot, good catch indeed.



================
Comment at: libcxx/include/type_traits:1335
+template <class _Tp>
+using __type_identity_t _LIBCPP_NODEBUG = typename __type_identity<_Tp>::type;
+
----------------
Mordante wrote:
> I'm a bit puzzled why this is the only one using `_LIBCPP_NODEBUG`. @ldionne do you know whether this inconsistency is intended.
> Note When we fix it, I prefer a separate patch.
We do use `_LIBCPP_NODEBUG` in a couple of other places. I think we only use it for internal-only typedefs, so this one looks fine to me. @EricWF could probably give more background on the intent behind this macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122017/new/

https://reviews.llvm.org/D122017